[sumac] fix: bugs with ExpandableTextArea toolbars & modals in problem editor [FC-0076] #1673
Conversation
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @pomegranited! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
pomegranited
force-pushed
the
jill/sumac/fix-problem-input
branch
from
451d417 to
2f8e373
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## open-release/sumac.master #1673 +/- ##
============================================================
Coverage ? 93.23%
============================================================
Files ? 1050
Lines ? 20420
Branches ? 4374
============================================================
Hits ? 19038
Misses ? 1322
Partials ? 60 ☔ View full report in Codecov by Sentry. |
pomegranited
force-pushed
the
jill/sumac/fix-problem-input
branch
from
2f8e373 to
e9ec2ad
Compare
…openedx#1646) * fix: when ExpandableTextArea is in a modal, the selection toolbar could not be clicked * fix: in ExpandableTextArea, shrink the "insert toolbar" that blocks the input * chore: ignore coverage of modal fixer * fix: make sure emoji/formula modals are working in the text editor too (cherry picked from commit 0b08d82)
pomegranited
force-pushed
the
jill/sumac/fix-problem-input
branch
from
e9ec2ad to
9dec798
Compare
pomegranited
changed the title
pomegranited
changed the title
Description
Backports the bugfixes from #1646 to Sumac.
Supporting information
Formatting Toolbar Blocking Text Input #1636
Testing instructions
See notes below.
Other information
imagebutton will not show in any of the editors.Partial support for library block assets is in Sumac, but adding full support requires backporting these feature PRs: feat: upload images from the TinyMCE in library editor #1458, test: fix contentContainer test #1516, fix: map image upload feature with enableImageUpload prop in TinyMceWidget #1527 (and more)